Fix linking error #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evq
reviewed
Feb 7, 2019
src/wrapper.cpp
Outdated
| } | ||
| } | ||
| const char* TokenException::what() const noexcept { return msg_.c_str(); } | ||
| const TokenException& TokenException::none() { |
Collaborator
There was a problem hiding this comment.
this should be moved under the NO_CXXEXCEPTIONS ifdef
bridiver
force-pushed
the
fix-linking-error
branch
from
1890958 to
ab9ba97
Compare
…pped and causes problems for the framework order file
bridiver
force-pushed
the
fix-linking-error
branch
from
ab9ba97 to
1cd2147
Compare
evq
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we probably don't want to merge this into master without providing an option to go back to thread_local, but should be fine for immediate needs