[CLOSED] Fixed status bar so it can add indicators to itself again

[core-ai-bot]

Issue by lkcampbell
Sunday Dec 22, 2013 at 15:33 GMT
Originally opened as adobe/brackets#6304

---

This fix addresses issue #5682. StatusBar.addIndicator() now adds the indicators to the DOM correctly.

---

lkcampbell included the following code: https://github.com/adobe/brackets/pull/6304/commits

[core-ai-bot]

Comment by lkcampbell
Sunday Dec 22, 2013 at 15:40 GMT

---

Just a couple of notes on this.

@njx indicated that he only wanted relative positioning for core features, so I named the new parameter for addIndicator with an underscore name _beforeID and indicated it is for CodeInspection internal use only in the documentation. Didn't know the exact style you guys use for this situation so that's my best guess.

I didn't add the new indicator to the very leftmost position, because I thought it would look weird if the "busy" indicator appeared in the middle of a bunch of indicators. So, I kept the "busy" indicator as the leftmost indicator always. If you don't like this, let me know and I can change it.

[core-ai-bot]

Comment by lkcampbell
Monday Dec 23, 2013 at 23:38 GMT

---

@redmunds, code review change committed.

[core-ai-bot]

Comment by lkcampbell
Tuesday Dec 24, 2013 at 15:43 GMT

---

@redmunds, code review changes committed.

[core-ai-bot]

Comment by redmunds
Thursday Dec 26, 2013 at 17:45 GMT

---

Done with review. Code looks good. Just one nit about comments.

[core-ai-bot]

Comment by lkcampbell
Friday Dec 27, 2013 at 03:38 GMT

---

@redmunds, code review changes committed.

[core-ai-bot]

Comment by redmunds
Friday Dec 27, 2013 at 17:32 GMT

---

Looks good. Merging.