[CLOSED] Nothing open in editor area after using Close Others

[core-ai-bot]

Issue by peterflynn
Friday Nov 01, 2013 at 00:22 GMT
Originally opened as adobe/brackets#5800

---

1. Open a few files into the working set
2. Select one in the middle
3. Close Others, Close Others Above, or Close Others Below

Result:
The correct files are closed, but the editor area is cleared and nothing is selected in the working set (even if there are still items in it).

Expected:
File you right-clicked is still selected in working set and displayed in editor area.

Workaround:
Click the file again. The original editor comes back and no changes, state, etc. are lost.

[core-ai-bot]

Comment by peterflynn
Friday Nov 01, 2013 at 00:23 GMT

---

This may have been working originally and then broken by some of the Image-close work... but if so, it's a good example of why features like this should have unit tests before landing.

[core-ai-bot]

Comment by peterflynn
Friday Nov 01, 2013 at 00:46 GMT

---

I think this is caused by this line:

DocumentManager.removeListFromWorkingSet(savedFiles, (clearCurrentDoc || true));

Notice how the 2nd arg is forced to always be true. I think we would only want it to be true when the current document isn't in the working set.

Looks like that change was made by@sathyamoorthi in bd4018d55 (PR #4590), so@JeffryBooher is the assignee winner for now...

[core-ai-bot]

Comment by sathyamoorthi
Friday Nov 01, 2013 at 00:52 GMT

---

@peterflynn yes. I noticed and gave pull request for that a long ago. :) adobe/brackets#5497.

[core-ai-bot]

Comment by peterflynn
Friday Nov 01, 2013 at 01:34 GMT

---

Ok, marking 'fix in progress.' Sorry it didn't get merged during the same sprint...

[core-ai-bot]

Comment by sathyamoorthi
Friday Nov 01, 2013 at 01:44 GMT

---

@peterflynn sure. np.

That was a clear mistake made by me. I didn't manually check before i did my last commit on that PR. I ran "Close Others" unit test and did a commit. Later, i realized that issue and added below line in unit test file. So you can rely that test file now. :)

expect(DocumentManager.getCurrentDocument()).not.toBe(null);

[core-ai-bot]

Comment by JeffryBooher
Wednesday Nov 13, 2013 at 01:48 GMT

---

open to@ingorichter per our meeting today