[CLOSED] Spanish strings for Sprint 33

[core-ai-bot]

Issue by jbalsas
Thursday Oct 24, 2013 at 21:32 GMT
Originally opened as adobe/brackets#5676

---

Updated spanish strings and getting started up to sprint 33.

@TomMalbran Care to review?

---

jbalsas included the following code: https://github.com/adobe/brackets/pull/5676/commits

[core-ai-bot]

Comment by TomMalbran
Thursday Oct 24, 2013 at 22:00 GMT

---

Done with the review. Did this included the Sprint 32 string updates? By the index, it seems like it does, but not sure if there were any string changes lately.

[core-ai-bot]

Comment by jbalsas
Thursday Oct 24, 2013 at 22:19 GMT

---

Hey,@TomMalbran, I've pushed a commit with the discussed fixes.

This should include all the string changes up to sprint 33, since I use the localization extension to compare the spanish locale with the root one ;)

[core-ai-bot]

Comment by TomMalbran
Thursday Oct 24, 2013 at 22:24 GMT

---

Great. Does that tool also checks for English string changes and not just additions and deletions?

[core-ai-bot]

Comment by jbalsas
Thursday Oct 24, 2013 at 22:31 GMT

---

No, currently it just does static compare between the current state of the files but knows nothing about the history of the strings... that's a great idea worth exploring though ;)

[core-ai-bot]

Comment by TomMalbran
Thursday Oct 24, 2013 at 22:41 GMT

---

I was doing diff checks between the latest root string.js and the one at which the es strings was at. In this case the Sprint 32 strings: http://diffchecker.com/r3xa0z8u

It seem like only LIVE_DEV_NEED_HTML_MESSAGE needs a string update.

[core-ai-bot]

Comment by jbalsas
Thursday Oct 24, 2013 at 22:48 GMT

---

Updated and pushed. Good catch! (I'll see next week if I can use the git extension somehow to diff the changes in the root strings up to a point to detect these cases...)

Also, I was thinking about translating brackets-update as well. Would you be up to review those as well starting next sprint?

[core-ai-bot]

Comment by TomMalbran
Thursday Oct 24, 2013 at 22:53 GMT

---

That would be great.

And yes, I can review those too. Is it too late for this sprint?

One final comment before ready to merge.

[core-ai-bot]

Comment by jbalsas
Thursday Oct 24, 2013 at 23:00 GMT

---

Ok, I've forced pushed your last comment, so this should be good to go :)

(I'll be sending you the brackets-updates translations for this sprint shortly)

[core-ai-bot]

Comment by TomMalbran
Thursday Oct 24, 2013 at 23:12 GMT

---

Great. Merging :)