[CLOSED] Fixed: #1863 Selector width info is wrong when no space before '{'

[core-ai-bot]

Issue by WebsiteDeveloper
Saturday Mar 09, 2013 at 12:25 GMT
Originally opened as adobe/brackets#3082

---

Fixed: #1863 and also fixed a few other cases where selection was incorrect

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3082/commits

[core-ai-bot]

Comment by redmunds
Thursday Mar 14, 2013 at 02:58 GMT

---

This looks good.

Can you add some unit tests to the CSSUtils tests with rules as follows:

• rule with no whitespace between selector and opening brace
• rule with the brace on the line following as the selector with no indent
• rule with the brace on the line following as the selector and indented

[core-ai-bot]

Comment by redmunds
Thursday Mar 14, 2013 at 16:31 GMT

---

Done with initial review.

[core-ai-bot]

Comment by WebsiteDeveloper
Thursday Mar 14, 2013 at 17:31 GMT

---

@redmunds i added the unit tests and also fixed a few more edge cases

[core-ai-bot]

Comment by redmunds
Thursday Mar 14, 2013 at 18:00 GMT

---

Done with second review.

[core-ai-bot]

Comment by WebsiteDeveloper
Thursday Mar 14, 2013 at 18:19 GMT

---

@redmunds ready for final review

[core-ai-bot]

Comment by redmunds
Thursday Mar 14, 2013 at 21:19 GMT

---

Looks good. Merging.