[CLOSED] MoveFileOrDirectoryToTrash implemented

[core-ai-bot]

Issue by timburgess
Tuesday Jul 23, 2013 at 07:33 GMT
Originally opened as adobe#284

---

If a Trash directory exists, do a kernelspace copy to trash dir before deleting the file and display update callback

---

timburgess included the following code: https://github.com/adobe/brackets-shell/pull/284/commits

[core-ai-bot]

Comment by njx
Tuesday Jul 23, 2013 at 18:16 GMT

---

Just made a few drive-by comments because I felt like looking at C code for old times sake :)

[core-ai-bot]

Comment by timburgess
Tuesday Jul 23, 2013 at 21:26 GMT

---

No worries & yes, all good comments, even if for old times sake :-)

• I'll use the safer syscalls instead
• There is unfortunately NO common way that distributions implement Trash. The best I could find was http://www.freedesktop.org/wiki/Specifications/ but most distributions don't implement it. Red Hat and Ubuntu don't. The hard path I have implemented is for Ubuntu and the logic will simply fall thru to a delete if it's not Ubuntu.
• I believe that an existing Trash file will be overwritten but I will test for this case

[core-ai-bot]

Comment by peterflynn
Tuesday Jul 23, 2013 at 21:39 GMT

---

@njx Do you get nostalgic about old dentist visits too? ;-)

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 23, 2013 at 05:32 GMT

---

Closing in favor of #304