Skip to content

Conversation

@jonathan343
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Base: 93.49% // Head: 93.45% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (253442b) compared to base (2df5c5b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2817      +/-   ##
===========================================
- Coverage    93.49%   93.45%   -0.05%     
===========================================
  Files           63       63              
  Lines        13346    13381      +35     
===========================================
+ Hits         12478    12505      +27     
- Misses         868      876       +8     
Impacted Files Coverage Δ
botocore/docs/bcdoc/docstringparser.py 99.25% <100.00%> (+0.07%) ⬆️
botocore/docs/bcdoc/restdoc.py 96.42% <100.00%> (ø)
botocore/docs/bcdoc/style.py 95.46% <100.00%> (-0.74%) ⬇️
botocore/compat.py 91.33% <0.00%> (-1.34%) ⬇️
botocore/httpsession.py 91.40% <0.00%> (-0.40%) ⬇️
botocore/utils.py 79.07% <0.00%> (-0.13%) ⬇️
botocore/endpoint_provider.py 99.35% <0.00%> (-0.01%) ⬇️
botocore/handlers.py 96.44% <0.00%> (+<0.01%) ⬆️
botocore/client.py 97.84% <0.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jonemo jonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I had a few comments where the code seems unnecessarily complex.

Copy link
Contributor

@jonemo jonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@jonathan343 jonathan343 merged commit 2431305 into boto:develop Dec 5, 2022
aws-sdk-python-automation added a commit that referenced this pull request Dec 5, 2022
* release-1.29.23:
  Bumping version to 1.29.23
  Update to latest partitions and endpoints
  Update to latest models
  Fixed doc issues around links and nested formatting (#2817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants