cmd/scollector: fastly status.io monitoring and status.io lib

[kylebrandt]

No description provided.

[kylebrandt]

Build failure above doesn't have to do with PR, just a timeout when shutting down bosun - so travis thing I think.

[captncraig]

a comment describing what a regex is looking for is always useful.

[captncraig]

My only issue is the size of the "library" component compared to what we actually use. I'm feeling that one of the following should be true:

1. It is a general purpose status.io library that should be an external repo and vendored in.
2. It is specific to the needs of this collector and should be included in bosun, but only include the bits we use now.

If this is too pedantic, I'm ok either way.

[kylebrandt]

I can vendor it. Make a new repo under bosun-monitor?
On May 16, 2016 11:51 AM, "Craig Peterson" [email protected] wrote:

My only issue is the size of the "library" component compared to what we
actually use. I'm feeling that one of the following should be true:

1. It is a general purpose status.io library that should be an
   external repo and vendored in.
2. It is specific to the needs of this collector and should be
   included in bosun, but only include the bits we use now.

If this is too pedantic, I'm ok either way.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1735 (comment)

[captncraig]

sounds good to me