Skip to content

Commit e377395

Browse files
chore(ADR): explain the decision regarding new DB test configurations (#3186)
Closes https://bonitasoft.atlassian.net/browse/BPM-285
1 parent fba5361 commit e377395

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

buildSrc/src/main/groovy/org/bonitasoft/engine/gradle/docker/DatabaseExtraConfiguration.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import org.gradle.api.Project
66
@Canonical
77
class DatabaseExtraConfiguration {
88
/**
9-
* Include an additional module in the test classpath
9+
* Include an additional project in the test classpath
1010
*/
11-
Project includeTestModule
11+
Project includeTestProject
1212
/**
1313
* Excludes test class patterns (e.g. '**/*Test.class') applied to this database vendor.
1414
* It can be combined with {@link #excludeTags}.

buildSrc/src/main/groovy/org/bonitasoft/engine/gradle/docker/DockerDatabaseContainerTasksCreator.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@ class DockerDatabaseContainerTasksCreator {
140140
description = "Runs slow integration test suite on $vendor.name database."
141141
systemProperty "bonita.version", project.version
142142
jvmArgs += ['--add-opens', 'java.base/java.util=ALL-UNNAMED', '--add-opens', 'java.base/java.lang=ALL-UNNAMED', '-Dfile.encoding=UTF-8']
143-
if (extension."${vendor.name}"?.includeTestModule) {
144-
testClassesDirs += extension."${vendor.name}".includeTestModule.sourceSets.test.output.classesDirs
145-
classpath += extension."${vendor.name}".includeTestModule.sourceSets.test.runtimeClasspath
143+
if (extension."${vendor.name}"?.includeTestProject) {
144+
testClassesDirs += extension."${vendor.name}".includeTestProject.sourceSets.test.output.classesDirs
145+
classpath += extension."${vendor.name}".includeTestProject.sourceSets.test.runtimeClasspath
146146
}
147147
classpath += project.files(project.configurations.drivers)
148148
if (extension."${vendor.name}"?.excludes) {

services/bonita-scheduler/src/test/java/org/bonitasoft/engine/scheduler/impl/AbstractQuartzJobTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public void before() {
5252
@Test
5353
public void should_not_unschedule_job_on_exception() throws Exception {
5454
// job should never throw an exception and be handled by the JobWrapper
55-
// we do not unschedule the job in that case. we don't want to loose the job
55+
// we do not unschedule the job in that case. we don't want to lose the job
5656
doReturn(jobThatFails()).when(schedulerService).getPersistedJob(any());
5757

5858
try {

0 commit comments

Comments
 (0)