Skip to content

Conversation

@samedit66
Copy link
Contributor

Hello! While reading the README, I noticed that there was no style modifier called visible mentioned anywhere. I added it, along with some tests for it

@bluenote10
Copy link
Owner

Could you clarify what that means, or give some context?

I don't really understand what "visible" is supposed to do, because everything is "visible" already 🤔

Does the upstream chalk have this feature?

@samedit66
Copy link
Contributor Author

samedit66 commented Oct 10, 2025

Sure. The picture below I took from the README of yachalk. Maybe I'm a bit blind but before my PR there was no such feature in yachalk source code. Speaking about chalk, its README also mentions visible in the same section as yachalk README does: https://github.com/chalk/chalk?tab=readme-ov-file#styles

image

@bluenote10
Copy link
Owner

Ah, thanks for the hint -- my eyes somehow didn't see "visible" I guess 😂

The name is a bit strange, if I were to name it I'd go for chalk.red.ifpossible("foo"), but let's stick to chalk and the copy/pasted readme.

I'll briefly close/re-open the PR in an attempt to trigger CI, which for some reason got deactivated...

@bluenote10 bluenote10 closed this Oct 10, 2025
@bluenote10 bluenote10 reopened this Oct 10, 2025
@bluenote10
Copy link
Owner

Looks like there was a minor linter failure...

@bluenote10 bluenote10 merged commit fbc09e9 into bluenote10:master Oct 10, 2025
6 checks passed
@bluenote10
Copy link
Owner

Thanks for the contribution!

I've just published version 0.1.8 on pypi which includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants