Skip to content

Conversation

@sshah-asymmetrik
Copy link
Contributor

@sshah-asymmetrik sshah-asymmetrik commented Mar 19, 2021

This PR contains modifications to the Feedback routes, controller, service, and model. This is being done with the intention of expanding the Feedback functionality to be more like other admin services (like user service) and add some new functionality as well. There is an accompanying PR for the ngx-starter with the UI changes that would use this server functionality (bluehalo/ngx-starter#192).

Change Summary:

  • Added 3 new fields to Feedback model, status, assignee, and updated. These are made with the intention of allowing a sort of in-app tracking system to allow admins to organize handling feedback.
  • Added 2 new routes and accompanying controller and service methods to update status and feedback individually.
  • Modified CSV export to use a column config posted with the export request instead of defaulting to including all columns. This allows users to select which columns they want exported based on what columns they have showing in the UI (modeled after User service).
  • Modified the search to take in filter queries to enable UI Quick Filters (modeled after User service).

Verification Steps
While these updates can be verified using Postman or something, it's easier to do it through the UI. See bluehalo/ngx-starter#192 for verification steps that include this functionality.

Let me know what I can improve! Thanks!

@sshah-asymmetrik
Copy link
Contributor Author

sshah-asymmetrik commented Mar 23, 2021

  • Add test coverage for new errors

@brianghig brianghig merged commit e82bbd5 into develop Mar 25, 2021
@brianghig brianghig deleted the feat/feedback-update branch March 25, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants