Skip to content

Conversation

@effigies
Copy link
Collaborator

@effigies effigies commented Dec 7, 2018

This may be the root of the Pandas nightly failures.

This may be the root of the Pandas nightly failures.
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #315 into master will increase coverage by 1.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #315      +/-   ##
=========================================
+ Coverage   73.03%   74.5%   +1.47%     
=========================================
  Files          24      24              
  Lines        2551    2742     +191     
  Branches      624     711      +87     
=========================================
+ Hits         1863    2043     +180     
- Misses        506     514       +8     
- Partials      182     185       +3
Flag Coverage Δ
#unittests 74.5% <ø> (+1.47%) ⬆️
Impacted Files Coverage Δ
bids/layout/layout.py 81.65% <0%> (+6.18%) ⬆️
bids/config.py 83.01% <0%> (+10.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9ac08...0937210. Read the comment docs.

@tyarkoni
Copy link
Collaborator

tyarkoni commented Dec 7, 2018

Wooooo!

@effigies
Copy link
Collaborator Author

effigies commented Dec 7, 2018

I'm going to submit a PR to pandas to fix this, rather than add a dependency we don't directly use.

@effigies effigies changed the title FIX: Add enum34 dependency for Python 2.7 CI: Disable allowed failures for Python 2.7 nightly tests Dec 11, 2018
@effigies
Copy link
Collaborator Author

Fix should be in: pandas-dev/pandas#24170

I expect this will fail now, but can be rerun in the morning and will pass.

@effigies effigies merged commit dd8c9bc into master Dec 12, 2018
@effigies effigies deleted the fix/python27 branch December 12, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants