Skip to content

The spectrum charts improvements. #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
1f5e4a4
The FFT is used power 2 input length to get maximal fft performance
demvlad May 13, 2025
1ade102
Added Power spectral density curves chart
demvlad May 13, 2025
e19b709
The spectrum magnitude is computed by complex Re and Im value
demvlad May 13, 2025
97b6ed1
Added functions to compute PSD by RPM and Throttle
demvlad May 10, 2025
d0ea63f
Added drawing heat map for PSD values
demvlad May 10, 2025
4d36d7f
Added switch to select PSD by throttle or RPM charts
demvlad May 10, 2025
2ae153f
Resolved issue of limit drawing psd value
demvlad May 10, 2025
6542364
Code style improvement
demvlad May 10, 2025
19baa2f
Code refactoring in src/graph_spectrum_calc.js
demvlad May 10, 2025
4d77b48
Resolved missing this. issue
demvlad May 10, 2025
3a82b42
Added PSD values label at mouse position cursor by Shift key
demvlad May 11, 2025
28c0107
Added PSD values label on the mouse position cursor by Shift key at t…
demvlad May 11, 2025
54e75aa
Code refactoring
demvlad May 12, 2025
49b0776
The background heatmap PSD value is changed from -70 to -100dBm
demvlad May 12, 2025
1fa0e64
Added PSD value to maximal noise PSD marker
demvlad May 12, 2025
b0442a1
Removed needless spaces
demvlad May 12, 2025
9fff07b
The SPECTRUM_TYPE enum members are reordered
demvlad May 12, 2025
822bcbc
Code style improvement
demvlad May 12, 2025
3791145
Code refactoring
demvlad May 14, 2025
257d694
Resolved issue of wrong simple frequency spectrum data
demvlad May 14, 2025
b5e3b08
Code refactoring
demvlad May 14, 2025
5e59666
Improved fill data into fft input array
demvlad May 14, 2025
75f36de
Improved computing of PSD
demvlad May 14, 2025
7c673a1
Code refactoring
demvlad May 14, 2025
1fe7393
Resolved issue computing frequency with maximal noise at the simple s…
demvlad May 15, 2025
4ec3c46
Improved computing of vsBinIndex values
demvlad May 15, 2025
6fac4f8
Code refactoring: using of named constant
demvlad May 15, 2025
5e1edf0
The top margin at heatmaps charts applies for RPM axis only
demvlad May 16, 2025
91fd9c4
Resolved issue of filters drawing at the PSD charts
demvlad May 16, 2025
dcfd823
Improved computing of top margin value at vs RPM charts
demvlad May 16, 2025
39ff240
Set properly value for overdrawSpectrumType select element position
demvlad May 17, 2025
f357404
The vertical slider shifts the PSD charts dBm range
demvlad May 17, 2025
4cdc2f4
Improved draw simple spectrum code
demvlad May 20, 2025
27e9873
Limit fft input count for simple spectrum chart to get normal charts …
demvlad May 20, 2025
062a353
Using power at 2 fft inputsize to compute PSD ws throttle and RPM
demvlad May 20, 2025
e1e522d
Resolved issues of using power at 2 values
demvlad May 20, 2025
25c94ec
Resolved issue wrong PSD values matrix size
demvlad May 21, 2025
518ee59
Impoved PSD heat map charts vertical slider control: the avaiable dBm…
demvlad May 21, 2025
427688a
Code style improvement
demvlad May 21, 2025
989ff73
Code refactoring
demvlad May 22, 2025
f3f0f4e
Added separated own vertical slider for PSD ranges shift
demvlad May 23, 2025
74f03d6
Added vertical slider to control drawing PSD low level
demvlad May 23, 2025
47660a9
Code refactoring
demvlad May 23, 2025
76cbc3c
Added text label for the PSD vertical sliders
demvlad May 23, 2025
0e50e64
Code refactoring
demvlad May 23, 2025
7024a54
replaced PSD dBm values labels
demvlad May 25, 2025
25af58f
Replaced dBm range shift slider at PSD heat map charts
demvlad May 26, 2025
1a8e681
Code refactoring: use two different function to compute frequency by …
demvlad May 26, 2025
d3de155
Resolved Missing trailing comma issue
demvlad May 28, 2025
1e4f619
Resolved missing trailing coma issue
demvlad May 28, 2025
86a23fc
Added full dBm range min and max values control by using spin number …
demvlad May 28, 2025
6f9c1ff
Resolved missing trailing coma issues
demvlad May 29, 2025
7b034ac
The number input fields spin buttons are visible now
demvlad May 29, 2025
d7dbd91
Added Ctrl key for double mouse click to set PSD range values as default
demvlad May 30, 2025
734fca8
Improved PSD range values validation logic
demvlad May 30, 2025
b751dd9
Code style improvement
demvlad May 30, 2025
4d457ce
Improved console errors output
demvlad May 30, 2025
7399c88
Made closer PSD control placement
demvlad May 30, 2025
e0488a2
Code style improvement
demvlad May 31, 2025
5476af5
Resolved undue rectangle issue at the spectrum chart
demvlad Jun 2, 2025
bcf5e6f
The PSD caption is changed
demvlad Jun 2, 2025
4423b52
The extra line is removed
demvlad Jun 2, 2025
fb5a66b
The extra line is removed in src/graph_spectrum_calc.js
demvlad Jun 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,11 @@ <h4>Workspace</h4>
<select id="spectrumTypeSelect">
<option value="0">Frequency</option>
<option value="1">Freq. vs Throttle</option>
<option value="3">Freq. vs RPM</option>
<option value="2">Error vs Setpoint</option>
<option value="2">Freq. vs RPM</option>
<option value="3">Power Spectral Density</option>
<option value="4">PSD vs Throttle</option>
<option value="5">PSD vs RPM</option>
<option value="6">Error vs Setpoint</option>
</select>
</div>

Expand Down Expand Up @@ -490,6 +493,22 @@ <h4>Workspace</h4>
/>
<input id="analyserZoomY" class="onlyFullScreen" type="range" name="analyserZoomY" value="100" min="10" max="1000" step="10" list="analyserZoomYTicks"
/>
<input id="analyserLowLevelPSD" class="onlyFullScreen" type="number" name="analyserLowLevelPSD" value="-40" min="-40" max="10" step="5"
/>
<input id="analyserMaxPSD" class="onlyFullScreen" type="number" name="analyserMaxPSD" value="10" min="-35" max="100" step="5"
/>
<input id="analyserMinPSD" class="onlyFullScreen" type="number" name="analyserMinPSD" value="-40" min="-100" max="5" step="5"
/>
<label id="analyserMaxPSDLabel" name="analyserMaxPSDLabel" class="onlyFullScreen" >
Max&nbsp;dBm
</label>
<label id="analyserMinPSDLabel" name="analyserMinPSDLabel" class="onlyFullScreen" >
Min&nbsp;dBm
</label>
<label id="analyserLowLevelPSDLabel" name="analyserLowLevelPSDLabel" class="onlyFullScreen" >
Limit&nbsp;dBm
</label>

<datalist id="analyserZoomXTicks">
<option>100</option>
<option>200</option>
Expand Down
76 changes: 75 additions & 1 deletion src/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,12 @@ html.has-analyser-fullscreen.has-analyser
display: block;
}

html.has-analyser-fullscreen.has-analyser
.analyser
label:not(.onlyFullScreenException) {
display: block;
}

#analyser,
#log-seek-bar {
z-index: 10;
Expand Down Expand Up @@ -616,7 +622,7 @@ html.has-analyser-fullscreen.has-analyser
height: 0;
overflow: hidden;
opacity: 0;
left: 120px;
left: 130px;
float: left;
z-index: 9;
position: absolute;
Expand Down Expand Up @@ -670,6 +676,7 @@ html.has-analyser-fullscreen.has-analyser
top: 10px;
float: right;
}

.analyser input#analyserZoomY {
width: 10px;
height: 100px;
Expand All @@ -678,6 +685,65 @@ html.has-analyser-fullscreen.has-analyser
top: 30px;
}

.analyser input#analyserMinPSD::-webkit-inner-spin-button,
.analyser input#analyserMinPSD::-webkit-outer-spin-button,
.analyser input#analyserMaxPSD::-webkit-inner-spin-button,
.analyser input#analyserMaxPSD::-webkit-outer-spin-button,
.analyser input#analyserLowLevelPSD::-webkit-inner-spin-button,
.analyser input#analyserLowLevelPSD::-webkit-outer-spin-button {
-webkit-appearance: auto !important;
-moz-appearance: auto !important;
appearance: auto !important;
opacity: 1 !important;
height: auto !important;
width: auto !important;
}

.analyser input#analyserMaxPSD {
width: 50px;
height: 20px;
left: 0px;
top: 30px;
}

.analyser input#analyserMinPSD {
width: 50px;
height: 20px;
left: 0px;
top: 55px;
}

.analyser input#analyserLowLevelPSD {
width: 50px;
height: 20px;
left: 0px;
top: 80px;
}

.analyser label#analyserMaxPSDLabel {
position:absolute;
color:gray;
left: 0px;
top: 30px;
font-size: 12px;
}

.analyser label#analyserMinPSDLabel {
position:absolute;
color:gray;
left: 0px;
top: 55px;
font-size: 12px;
}

.analyser label#analyserLowLevelPSDLabel {
position:absolute;
color:gray;
left: 0px;
top: 80px;
font-size: 12px;
}

.analyser input.onlyFullScreen {
display: none;
padding: 3px;
Expand All @@ -686,6 +752,14 @@ html.has-analyser-fullscreen.has-analyser
position: absolute;
}

.analyser label.onlyFullScreen {
display: none;
padding: 3px;
margin-right: 3px;
z-index: 9;
position: absolute;
}

.analyser,
.map-container,
.log-seek-bar {
Expand Down
Loading