Skip to content
This repository was archived by the owner on Dec 23, 2022. It is now read-only.

Conversation

@bellingard
Copy link
Owner

No description provided.

*/
public class Foo {

public int i;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Document this public field. rule
MAJOR Make i a static final constant or non-public and provide accessors if needed. rule

@ghost
Copy link

ghost commented May 10, 2016

SonarQube analysis reported 3 issues

  • MAJOR 3 major

Watch the comments in this conversation to review them.

throw new UnsupportedOperationException("Can't divide by zero!");
}

System.out.println("foo");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants