-
Notifications
You must be signed in to change notification settings - Fork 0
chore: remove legacy scripts and scrub docs to CI/CD pull-based deployment #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…yment\n\n- remove legacy-scripts/ directory\n- update README.md, README.Docker.md, DEPLOY-QUICKSTART.md, docs/ci-cd-deployment.md\n- update .github/copilot-instructions.md note on legacy scripts removal\n- clean .dockerignore of removed script entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all legacy local build and deployment scripts, replacing them with a clean CI/CD-focused deployment workflow. The changes eliminate confusion between deprecated local Docker scripts and the current pull-based deployment model.
Key changes:
- Complete removal of the
legacy-scripts/directory containing all deprecated PowerShell and shell scripts - Documentation updates to replace script references with guidance on pulling pre-built images from CI/CD
- Configuration cleanup to remove references to deleted scripts
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| legacy-scripts/ | All files removed - PowerShell and shell scripts for local Docker builds and Pi deployments |
| README.md | Replaced script deployment section with links to deployment guides emphasizing CI/CD workflow |
| README.Docker.md | Removed scattered script references and cleaned up formatting inconsistencies |
| DEPLOY-QUICKSTART.md | Removed script-based deployment flows, focusing on pull and compose commands |
| docs/ci-cd-deployment.md | Simplified deprecated files section to note they've been removed |
| .github/copilot-instructions.md | Updated to clarify legacy scripts are fully removed and should not be reintroduced |
| .dockerignore | Removed entries for deleted deployment scripts |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
README.Docker.md:75
- Orphaned PowerShell code block marker. This appears to be a formatting error where a code block was started but not properly closed or the content was removed.
The workflow creates multiple tags:```powershell
This PR removes confusing legacy local build/deploy scripts and updates documentation to reflect the CI/CD-first, pull-based deployment workflow.
Changes
Rationale
How to validate
legacy-scripts,deploy-to-pi.ps1,build-docker-windows.ps1,deploy.sh,deploy.ps1,load-and-deploy.sh– only the single instruction note remainsNotes