Skip to content

Conversation

@Fortinbra
Copy link
Collaborator

This PR removes confusing legacy local build/deploy scripts and updates documentation to reflect the CI/CD-first, pull-based deployment workflow.

Changes

  • Remove legacy-scripts/ directory (build-docker-windows.ps1, deploy-to-pi.ps1, deploy.ps1, deploy.sh, docker-compose.old.yml, load-and-deploy.sh, README.md)
  • README.md: Replace one-command script ref with clean deployment pointers to DEPLOY-QUICKSTART.md and README.Docker.md
  • README.Docker.md: Strip script references; focus on pulling pre-built images and docker compose on target
  • DEPLOY-QUICKSTART.md: Remove script flows; add simple pull + up -d flow and common commands
  • docs/ci-cd-deployment.md: Replace deprecated-files list with a concise note that they’re removed
  • .github/copilot-instructions.md: Clarify legacy scripts fully removed, do not reintroduce
  • .dockerignore: Drop entries for removed scripts

Rationale

  • Prevent confusion with unsupported local build/deploy paths
  • Align all docs with section 34 of Copilot Instructions and the CI/CD pipeline

How to validate

  • grep repo for legacy-scripts, deploy-to-pi.ps1, build-docker-windows.ps1, deploy.sh, deploy.ps1, load-and-deploy.sh – only the single instruction note remains
  • Follow DEPLOY-QUICKSTART.md to deploy on Raspberry Pi using docker compose

Notes

  • No runtime code changed; only deletions and documentation updates
  • CI unaffected

…yment\n\n- remove legacy-scripts/ directory\n- update README.md, README.Docker.md, DEPLOY-QUICKSTART.md, docs/ci-cd-deployment.md\n- update .github/copilot-instructions.md note on legacy scripts removal\n- clean .dockerignore of removed script entries
Copilot AI review requested due to automatic review settings October 11, 2025 03:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all legacy local build and deployment scripts, replacing them with a clean CI/CD-focused deployment workflow. The changes eliminate confusion between deprecated local Docker scripts and the current pull-based deployment model.

Key changes:

  • Complete removal of the legacy-scripts/ directory containing all deprecated PowerShell and shell scripts
  • Documentation updates to replace script references with guidance on pulling pre-built images from CI/CD
  • Configuration cleanup to remove references to deleted scripts

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
legacy-scripts/ All files removed - PowerShell and shell scripts for local Docker builds and Pi deployments
README.md Replaced script deployment section with links to deployment guides emphasizing CI/CD workflow
README.Docker.md Removed scattered script references and cleaned up formatting inconsistencies
DEPLOY-QUICKSTART.md Removed script-based deployment flows, focusing on pull and compose commands
docs/ci-cd-deployment.md Simplified deprecated files section to note they've been removed
.github/copilot-instructions.md Updated to clarify legacy scripts are fully removed and should not be reintroduced
.dockerignore Removed entries for deleted deployment scripts

Copilot AI review requested due to automatic review settings October 11, 2025 03:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

README.Docker.md:75

  • Orphaned PowerShell code block marker. This appears to be a formatting error where a code block was started but not properly closed or the content was removed.
The workflow creates multiple tags:```powershell

@Fortinbra Fortinbra merged commit 6fa0f45 into main Oct 11, 2025
1 check passed
@Fortinbra Fortinbra deleted the chore/remove-legacy-scripts branch October 11, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants