Skip to content

update help page with feature flags #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2019
Merged

update help page with feature flags #92

merged 3 commits into from
Feb 19, 2019

Conversation

microbit-mark
Copy link
Contributor

  • pass feature flags to help page in order to show/hide features
  • pass MicroPython version from editor to docs
  • replace static images of buttons in help with css/fa
  • some more readability edits

@microbit-carlos
Copy link
Collaborator

Hi Mark,
It all looks good and I think @microbit-rosslowe already reviewed this in the python-editor repo.
One last request I hope you don't mind. Can we update the header image to this one?
Since by default some of the buttons will not be shown (and all the icons are then showed and described below) I think it's probably better to provide a screenshot of the default header, rather than the full one.
header.png.zip

uses image with no flags enabled
@microbit-mark
Copy link
Contributor Author

microbit-mark commented Feb 19, 2019

hey @microbit-carlos. That makes sense. Ack. and done

Copy link
Collaborator

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you Mark!

@microbit-carlos microbit-carlos merged commit d2b620b into bbcmicrobit:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants