-
Notifications
You must be signed in to change notification settings - Fork 129
Remove hex manipulation code and use Nordic Intel Hex lib #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hex manipulation code and use Nordic Intel Hex lib #77
Conversation
Odd bug in Safari Version 12.0.1 (14606.2.104.1.1), using a micro:bit 1.3b:
I tested the basic, initial hello world script. In this PR, I get this hex file: When attempting to flash the process appears to time out, and when the micro:bit is ejected it needs to be disconnected and reconnected. The file works on my 1.5 if you rename to .hex:
The first time I didn't rename I got a FAIL.TXT, which mentioned something about a time out. But since trying again this flashed fine. |
Chrome downloads this as .hex, as expected, but this file still won't flash properly to the 1.3. On master, this produces a file that flashes fine. https://python.microbit.org/v/0 works fine, and will flash without renaming to .hex. |
adf0e67
to
206a6c6
Compare
@microbit-rosslowe I've updated the code to pad the code so that it works in older versions of DAPLink, could you test again? |
Thanks @microbit-carlos this works on both versions of DAPLink now. |
206a6c6
to
448bdbf
Compare
To keep all things related to the Intel Hex format and the MicroPython details contained in their own modules. There is no functional changes, just the refactor.
3457dae
to
e63207f
Compare
Uses https://github.com/NordicSemiconductor/nrf-intel-hex, included as
static/js/intel-hex.browser.js
.@microbit-rosslowe Can you review?