Skip to content

Fix function for IE10 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Fix function for IE10 #100

merged 2 commits into from
Mar 6, 2019

Conversation

microbit-sam
Copy link
Collaborator

Add var x =

@microbit-carlos
Copy link
Collaborator

This PR, up to commit cd06d55, is currently deployed in https://python.microbit.org/v/beta.

@microbit-carlos
Copy link
Collaborator

Looks like by adding the polyfills mentioned in #113 then it works in IE10 again, except for this issue.
Is this branch ready to be merged as it is?

@microbit-sam
Copy link
Collaborator Author

Yeah I think so!

@microbit-carlos
Copy link
Collaborator

I hope you don't mind I've done the minor touch on this branch, I'd like this in master before adding the IE polyfills.

@microbit-carlos microbit-carlos merged commit b94b798 into master Mar 6, 2019
@microbit-carlos microbit-carlos deleted the fix-function-ie10 branch March 6, 2019 19:36
@microbit-carlos microbit-carlos restored the fix-function-ie10 branch March 11, 2019 16:15
@microbit-carlos microbit-carlos deleted the fix-function-ie10 branch May 8, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants