Skip to content

Conversation

@bjorne
Copy link
Contributor

@bjorne bjorne commented Apr 23, 2025

Otherwise, the globs are interpreted by the shell which may lead to errors such as

zsh:1: no matches found: !*.bundle.js

In this example the command was

/usr/bin/rg [...] --glob !*.bundle.js [...]

and after this change will become

/usr/bin/rg [...] --glob '!*.bundle.js' [...]

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the docs (when adding new project types, configuration options, commands, etc)

Thanks!

Otherwise, the globs are interpreted by the shell which may lead to errors
such as

    zsh:1: no matches found: !*.bundle.js

In this example the command was

    /usr/bin/rg [...] --glob !*.bundle.js [...]

and after this change will become

    /usr/bin/rg [...] --glob '!*.bundle.js' [...]
@bbatsov bbatsov merged commit 2018db1 into bbatsov:master May 27, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants