Fix linking failure caused by always_link defaulting to False
#1626
+40
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adincebic
requested review from
aaronsky,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
adincebic
changed the title
always_ defaulting to Falsealways_link defaulting to False
adincebic
changed the title
always_link defaulting to Falsealways_link defaulting to False
Contributor
|
Ok; thank you. I guess we need that then. But that means alwayslink will always be False in embedded, and that the user can't override it, right? That's unfortunate. |
Contributor
Author
Indeed |
keith
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in #1608
Rule attributes can't be
None. The condition åalwayslink == Nonenever triggered because alwayslink was False, notNone`.