Upstream: Ensure that swift_synthesize_interface_aspect generates unique outputs
#1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uts. The aspect generated a file named `<target>.synthesized.swift`, which was incorrect if a target had multiple modules in its `SwiftInfo.direct_modules` field. It would also be incorrect to just switch to `<module name>.synthesized.swift`, because two targets could potentially re-export the same module. To fully disambiguate, we create an intermediate directory named for the target, and then use the module name as the filename in that directory. PiperOrigin-RevId: 740414505
luispadron
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
referenced
this pull request
May 29, 2025
…uts. The aspect generated a file named `<target>.synthesized.swift`, which was incorrect if a target had multiple modules in its `SwiftInfo.direct_modules` field. It would also be incorrect to just switch to `<module name>.synthesized.swift`, because two targets could potentially re-export the same module. To fully disambiguate, we create an intermediate directory named for the target, and then use the module name as the filename in that directory. PiperOrigin-RevId: 740414505
aaronsky
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: 634d0d1
The aspect generated a file named
<target>.synthesized.swift, which was incorrect if a target had multiple modules in itsSwiftInfo.direct_modulesfield. It would also be incorrect to just switch to<module name>.synthesized.swift, because two targets could potentially re-export the same module.To fully disambiguate, we create an intermediate directory named for the target, and then use the module name as the filename in that directory.
PiperOrigin-RevId: 740414505