Upstream: Only pass the strict Obj-C include paths from _direct_ dependencies to compilation actions #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
referenced
this pull request
May 18, 2025
…o compilation actions. The `compilation_context_for_explicit_module_compilation` function handles collecting the strict includes from `SwiftInfo`s and we're already using that function when compiling the header module for a mixed-language `swift_library`, so we can simply reuse that logic here. PiperOrigin-RevId: 720632323
aaronsky
approved these changes
May 18, 2025
…ndencies to compilation actions The `compilation_context_for_explicit_module_compilation` function handles collecting the strict includes from `SwiftInfo`s and we're already using that function when compiling the header module for a mixed-language `swift_library`, so we can simply reuse that logic here. Upstreams: f08dc0c
luispadron
force-pushed
the
luis/cp-f08dc0
branch
from
d7ebe53 to
796b47b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compilation_context_for_explicit_module_compilationfunction handles collecting the strict includes fromSwiftInfos and we're already using that function when compiling the header module for a mixed-languageswift_library, so we can simply reuse that logic here.Upstreams: f08dc0c