Add instrumented files info to swift_binary and swift_compiler_plugin
#1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin` When using a `macos_unit_test` target whose test sources depend on a `swift_compiler_plugin` or `swift_binary` target, its sources are missing from the coverage manifest `COVERAGE_MANIFEST` env var that's passed to lcov. This change mirrors what the other targets do to add coverage instrumentation info so that they are available in the resulting coverage file.
sebastianv1
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
keith
approved these changes
Apr 25, 2025
luispadron
referenced
this pull request
May 18, 2025
This can be helpful for integration tests that contain swift_binary targets that are invoked in different configurations. PiperOrigin-RevId: 707265068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
macos_unit_testtarget whose test sources depend on aswift_compiler_pluginorswift_binarytarget, its sources are missing from the coverage manifestCOVERAGE_MANIFESTenv var that's passed to lcov.This change mirrors what the other targets do to add coverage instrumentation info so that they are available in the resulting coverage file.