Support index-import on all Xcode 16.x versions #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under.
luispadron
force-pushed
the
luis/update-hash-algorithm-for-xcode-16.3
branch
from
7bba507 to
7434ade
Compare
luispadron
changed the title
luispadron
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
keith
approved these changes
Apr 3, 2025
Member
|
an apple_support update will fix last_green |
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 4, 2025
In bazelbuild/rules_swift#1504 the index-import repository name was changed. rules_ios depends on the old name and thus breaks builds. It looks like these deps are unused (probably after we got rid of xcodeproj rules). This fixes builds in rules_xcodeproj: MobileNativeFoundation/rules_xcodeproj#3162
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 5, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under.
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 5, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 5, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 5, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 5, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 7, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 7, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
luispadron
added a commit
to MobileNativeFoundation/rules_xcodeproj
that referenced
this pull request
Apr 7, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1.
To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under.