Include swift_proto_library attrs in compilation #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianv1
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Jan 10, 2025
aaronsky
approved these changes
Jan 10, 2025
sebastianv1
force-pushed
the
sebastianv1/fix-proto-attrs
branch
from
b08a648 to
e778462
Compare
Using `package_name` or `copt` attributes weren't being propogated down into the actual swiftc compilation.
sebastianv1
force-pushed
the
sebastianv1/fix-proto-attrs
branch
from
e778462 to
8a8c211
Compare
luispadron
added a commit
that referenced
this pull request
Jan 17, 2025
) #1473 Co-authored-by: Sebastian Shanus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
package_nameorcoptattributes weren't being propogated down into the actual swiftc compilation.