Don't drop swift_overlay linking contexts when an overlay depends on another library that has an overlay
#1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n another library that has an overlay PiperOrigin-RevId: 665946723 (cherry picked from commit 6d0fc0f) Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 22, 2024
…n another library that has an overlay. PiperOrigin-RevId: 665946723
luispadron
approved these changes
Nov 18, 2024
brentleyjones
deleted the
bj/don-t-drop-swift_overlay-linking-contexts-when-an-overlay-depends-on-another-library-that-has-an-overlay
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 665946723
(cherry picked from commit 6d0fc0f)