Update docs to say that a source file should only be in a single swift_* target, and a swift_overlay should only be referenced by a single other target's aspect_hints
#1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
…ft_*` target, and a `swift_overlay` should only be referenced by a single other target's `aspect_hints` PiperOrigin-RevId: 664809810 (cherry picked from commit c593bc4) Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/update-docs-to-say-that-a-source-file-should-only-be-in-a-single-swift_-target-and-a-swift_overlay-should-only-be-referenced-by-a-single-other-target-s-aspect_hints
branch
from
3e349a2 to
c1c4791
Compare
brentleyjones
referenced
this pull request
Oct 22, 2024
…ft_*` target, and a `swift_overlay` should only be referenced by a single other target's `aspect_hints`. PiperOrigin-RevId: 664809810
luispadron
approved these changes
Oct 22, 2024
brentleyjones
deleted the
bj/update-docs-to-say-that-a-source-file-should-only-be-in-a-single-swift_-target-and-a-swift_overlay-should-only-be-referenced-by-a-single-other-target-s-aspect_hints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 664809810
(cherry picked from commit c593bc4)