Don't drop compilation contexts for private_deps when compiling the target that imports them
#1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 22, 2024
… target that imports them. This was rarely caught in practice because it only affects implicit module compilation and only matters when a dependency has includes that depend on custom header search paths provided by one of their C dependencies. PiperOrigin-RevId: 642596524
luispadron
approved these changes
Oct 22, 2024
brentleyjones
force-pushed
the
bj/don-t-drop-compilation-contexts-for-private_deps-when-compiling-the-target-that-imports-them
branch
from
4aed667 to
97e15ca
Compare
… target that imports them This was rarely caught in practice because it only affects implicit module compilation and only matters when a dependency has includes that depend on custom header search paths provided by one of their C dependencies. PiperOrigin-RevId: 642596524 (cherry picked from commit 8600c56) Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/don-t-drop-compilation-contexts-for-private_deps-when-compiling-the-target-that-imports-them
branch
from
97e15ca to
fcaa3ea
Compare
brentleyjones
deleted the
bj/don-t-drop-compilation-contexts-for-private_deps-when-compiling-the-target-that-imports-them
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was rarely caught in practice because it only affects implicit module compilation and only matters when a dependency has includes that depend on custom header search paths provided by one of their C dependencies.
PiperOrigin-RevId: 642596524
(cherry picked from commit 8600c56)