fix: remove system dependency on python3 #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replace_symlink implementation on darwin called out to the darwin system trampoline python3 version; this breaks with toolchains that have a hermetic SDKROOT (because the trampolines don't know how to read a relative value, and bazel registers it as an absolute path violation if it's absolute). realpath appears to have been added to the osx base system in Ventura (13), and according to https://endoflife.date/macos Monterey (12) went end of life back in September 2024.
jsharpe
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replace_symlink implementation on darwin called out to the darwin system trampoline python3 version; this breaks with toolchains that have a hermetic SDKROOT (because the trampolines don't know how to read a relative value, and bazel registers it as an absolute path violation if it's absolute).
realpath appears to have been added to the osx base system in Ventura (13), and according to https://endoflife.date/macos Monterey (12) went end of life back in September 2024.