Skip to content

Improve AutoPolygon::generateTriangles performance #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halx99 merged 7 commits into from
Oct 9, 2022
Merged

Improve AutoPolygon::generateTriangles performance #905

halx99 merged 7 commits into from
Oct 9, 2022

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Oct 8, 2022 •
edited
Loading

a. Avoid new many small p2t::Point
b. Add pod_vector for performance purpose

THIS PROJECT IS IN DEVELOPMENT MODE. Any pull requests should merge to branch dev, otherwise will be rejected immediately.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have checked readme and add important infos to this PR (if it needed).
  • An improved cpp-test/lua-test is not needed (explain why not, thanks).

thanks to @denghe

halx99 added 3 commits October 8, 2022 22:42
@halx99
Improve AutoPolygon::generateTriangles
71aca55 
a. Avoid new many small p2t::Point
b. Add pod_vector for performance purpose
@halx99
Fix ci
4eda9c5
@halx99
Fix ci
97b566a
@halx99 halx99 added the enhancement New feature or request label Oct 8, 2022
@halx99 halx99 added this to the 1.0 milestone Oct 8, 2022
crazyhappygame
crazyhappygame suggested changes Oct 9, 2022
View reviewed changes
crazyhappygame
crazyhappygame reviewed Oct 9, 2022
View reviewed changes
crazyhappygame
crazyhappygame approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@crazyhappygame crazyhappygame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@halx99 halx99 merged commit 5739331 into dev Oct 9, 2022
@halx99 halx99 deleted the improve-polygon-perf branch October 9, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crazyhappygame crazyhappygame crazyhappygame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@halx99 @crazyhappygame