Skip to content

chore(eventstream-serde-node): use Readable.from for serializing #4359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 24, 2023

Issue

N/A, noticed while browsing code.

Description

Removes the check for Readable.from as it's available in all Node.js supported by v3 (14+)
Docs: https://nodejs.org/api/stream.html#streamreadablefromiterable-options

Testing

The integration tests in transcribe streaming is successful

$ client-transcribe-streaming> node -v
v14.0.0

$ client-transcribe-streaming> yarn test:integration
yarn run v1.22.17
$ jest --config jest.integ.config.js
 PASS  test/index.integ.spec.ts (9.137 s)
  TranscribeStream client
    ✓ should stream the transcript (5081 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        9.192 s
Ran all test suites.
Done in 10.03s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review January 24, 2023 05:45
@trivikr trivikr requested a review from a team as a code owner January 24, 2023 05:45
@trivikr trivikr merged commit 2bc3759 into aws:main Jan 24, 2023
@trivikr trivikr deleted the eventstream-serde-node-serde-node branch January 24, 2023 17:15
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants