-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add stable order for smoke tests + restoring client codegen #3265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
8ac8276
26245eb
7365d54
1adf5ee
18adb72
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -155,9 +155,13 @@ def collect_available_models(models_dir: str, endpoint_rules_dir: str, legacy_ma | |
with open(models_dir + "/" + model_file_date[0], 'r') as json_file: | ||
model = json.load(json_file) | ||
#get service id. It has to exist, else continue | ||
if ("metadata" in model and "serviceId" in model["metadata"]): | ||
if ("metadata" in model and (("serviceId" in model["metadata"]) or ("serviceFullName" in model["metadata"])) ): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not according to python pep8 format There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, will make it more pythonic |
||
if key not in legacy_mapped_services: | ||
key = model["metadata"]["serviceId"] | ||
if "serviceId" in model["metadata"]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not a python-style code.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [] usage is valid here because of key check. I can switch to .get() in this case which is indeed less verbose |
||
key = model["metadata"]["serviceId"] | ||
else: | ||
key = model["metadata"]["serviceFullName"] | ||
|
||
#convert into smithy case convention | ||
key = key.lower().replace(' ', '-') | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead you could just use LinkedHashSet type to avoid an extra sort.