Skip to content

Update Smithy version for Smoke Test dependency #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Update Smithy version for Smoke Test dependency #3263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68db854
upgrade smithy version
sbera87 Jan 21, 2025
d165131
Merge branch 'main' into smoke
sbera87 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/code-generation/smithy/codegen/settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencyResolutionManagement {
versionCatalogs {
create("codegen") {
// Smithy dependencies
version("smithy", "1.51.0") // Centralize the version for Smithy-related dependencies
version("smithy", "1.53.0") // Centralize the version for Smithy-related dependencies
library("model", "software.amazon.smithy", "smithy-model").versionRef("smithy")
library("aws-traits", "software.amazon.smithy", "smithy-aws-traits").versionRef("smithy")
library("codegen-core", "software.amazon.smithy", "smithy-codegen-core").versionRef("smithy")
Expand Down
5 changes: 3 additions & 2 deletions tools/scripts/run_code_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,6 @@ def main():
return -1

print(f"Code generation done, (re)generated {len(done)} packages.") # Including defaults and partitions

#generate code using smithy for all discoverable clients
if (args["generate_smoke_tests"] and clients_to_build):

Expand All @@ -678,7 +677,9 @@ def main():
if generate_smoke_tests(smithy_services, json.dumps(smithy_c2j_data)) :
#move the output to generated folder
copy_cpp_codegen_contents(os.path.abspath("tools/code-generation/smithy/codegen"), "cpp-codegen-smoke-tests-plugin", os.path.abspath( "generated/smoke-tests"))

else:
print("Failed to generate code for smoke-tests")
return -1
return 0


Expand Down
Loading