Fix linking if SDK and app are built by GCC with 11 and 17 standards #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
approved these changes
Nov 9, 2022
sdavtaker
approved these changes
Nov 9, 2022
SergeyRyabinin
force-pushed
the
sr/cpp11cpp17partitions
branch
3 times, most recently
from
8d491f9 to
b64d9a3
Compare
SergeyRyabinin
force-pushed
the
sr/cpp11cpp17partitions
branch
from
b64d9a3 to
60fc399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101957
Discussion: #2184
Description of changes:
Strongly encapsulate blob symbol into the core module.
Export static const class member function from that module.
(a "classic" C++03 approach to deal with ODR issues by creating a dummy class with a static const member field/function)
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.