Rename SHAKE128_Init_x4 to the more general SHAKE_Init_x4 #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| (void) SHAKE128_Squeezeblocks_x4(out0, out1, out2, out3, state, nblocks); | ||
| } | ||
|
|
||
| static MLK_INLINE void mlk_shake128x4_init(mlk_shake128x4ctx *state) { |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'MLK_INLINE' [clang-diagnostic-error]
static MLK_INLINE void mlk_shake128x4_init(mlk_shake128x4ctx *state) {
^| (void) SHAKE_Init_x4(state); | ||
| } | ||
|
|
||
| static MLK_INLINE void mlk_shake128x4_release(mlk_shake128x4ctx *state) { |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'MLK_INLINE' [clang-diagnostic-error]
static MLK_INLINE void mlk_shake128x4_release(mlk_shake128x4ctx *state) {
^
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
=======================================
Coverage 78.16% 78.16%
=======================================
Files 689 689
Lines 118653 118653
Branches 16681 16681
=======================================
+ Hits 92740 92748 +8
+ Misses 25023 25016 -7
+ Partials 890 889 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
mldsa-native import needs SHAKE256_* functions. SHAKE256_Absorb_once_x4 and SHAKE256_Squeezeblocks_x4 are already supported. SHAKE256_Init_x4 is missing, however, SHAKE128_Init_x4 can be reused as-is for both SHAKE128 and SHAKE256. Therefore, generalizing the function avoids duplicates.
Description of changes:
Rename SHAKE128_Init_x4 to the more general function SHAKE_Init_x4, covering both SHAKE security levels.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.