fix(ec2): add proper handling for VPC endpoint service name prefix eu.amazonaws for new region eusc-de-east-1 for ECR & API Gateway services #36471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
For the new region
eusc-de-east-1will be launched in AWS European Sovereign Cloud, services like:-They have their VPC endpoint service name starts with prefix
eu.amazonawsrather than the defaultcom.amazonawsThis requires special handling similar to what's already implemented for China regions
cn-north-1&cn-northwest-1otherwise, while deploying, CloudFormation stacks will hit the error "The Vpc Endpoint Servicecom.amazonaws.eusc-de-east-1.ecr.dkrdoes not exist"Description of changes
In the file
packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts, I am updating the methodgetDefaultEndpointPrefix, adding special handling foreusc-de-east-1when services are['ecr.dkr', 'ecr.api', 'execute-api', 'securityhub']to returneu.amazonawsinstead ofcom.amazonaws. This is similar to what's already existing for China regions.Description of how you validated changes
I also updated
packages/aws-cdk-lib/aws-ec2/test/vpc-endpoint.test.tsto cover unit tests and was confirmed tests are passedChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license