Skip to content

fix(elasticache-alpha): deployment fails when serverlessCacheName or userGroupId is not specified #36459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mazyu36 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Draft

fix(elasticache-alpha): deployment fails when serverlessCacheName or userGroupId is not specified #36459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/@aws-cdk/aws-elasticache-alpha/lib/serverless-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,9 @@ export class ServerlessCache extends ServerlessCacheBase {
addConstructMetadata(this, props);

this.engine = props.engine ?? CacheEngine.VALKEY_LATEST;
this.serverlessCacheName = props.serverlessCacheName ?? Lazy.string({ produce: () => Names.uniqueId(this) });
this.serverlessCacheName = props.serverlessCacheName ?? Lazy.string({
produce: () => Names.uniqueResourceName(this, { maxLength: 40 }),
});
this.kmsKey = props.kmsKey;
this.vpc = props.vpc;
this.userGroup = props.userGroup;
Expand Down
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-elasticache-alpha/lib/user-group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ export class UserGroup extends UserGroupBase {

this.engine = props.engine ?? UserEngine.VALKEY;
this.userGroupName = props.userGroupName ?? Lazy.string({
// Elasticache not allowing uppercase user group id
produce: () => Names.uniqueId(this).toLocaleLowerCase(),
// User group ID max length is 40 characters
produce: () => Names.uniqueResourceName(this, { maxLength: 40 }).toLocaleLowerCase(),
});

if (props.users) {
Expand Down
Loading