fix minor unreachable code caused by t.Fatal #3372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the contribution! |
Realmonia
previously approved these changes
Sep 20, 2022
Contributor
|
Hi @Abirdcfly , can you please rebase this PR against latest dev? Thank you so much. |
Signed-off-by: Abirdcfly <[email protected]>
Contributor
Author
Done. |
yinyic
approved these changes
Oct 18, 2022
ubhattacharjya
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abirdcfly [email protected]
Summary
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Bug - Fixed some minor unreachable code caused by t.Fatal
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.