-
Notifications
You must be signed in to change notification settings - Fork 28
Support opening up container and service ports based on agent config YAML #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfb778c
to
d2738df
Compare
musa-asad
approved these changes
Sep 27, 2024
sky333999
reviewed
Sep 27, 2024
jefchien
reviewed
Sep 30, 2024
internal/manifests/collector/parser/receiver/receiver_collectd.go
Outdated
Show resolved
Hide resolved
jefchien
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing
a. Default ports for receivers --
Checking agent container ports
Checking agent service ports
b. Override ports for receivers --
Verified container ports and service ports are updated
c. Conflicting ports for receivers --
In this case, the JSON config ports are prioritized and duplicate ports from the YAML config are dropped.
Agent will also fail in this case with
d. Enabling health_check extension should create a liveness probe
Will create a liveness probe on the agent container
Although this scenario only works when the agent runs on a non sidecar mode - open-telemetry/opentelemetry-operator#571 and mounted on the application pod.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.