Skip to content

ISSUE-2420 add support for additional fields #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sga80 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ISSUE-2420 add support for additional fields #63

sga80 wants to merge 5 commits into from

Conversation

@sga80
Copy link
Contributor

@sga80 sga80 commented May 30, 2025 •
edited
Loading

Issue #2420

Description of changes:

  • Support additional fields - encryptionType, keyId and retentionPeriodHours.
  • All these fields are supported as an update operation similar to tags as these are not part of the create
  • Below is the screenshot of a test with encryption enabled
Screenshot 2025-05-29 at 7 59 35 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 May 30, 2025 03:04
@ack-prow
Copy link

ack-prow bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sga80
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow
Copy link

ack-prow bot commented May 30, 2025

Hi @sga80. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2025
sga80
sga80 commented May 30, 2025
View reviewed changes
test/e2e/tests/test_stream.py Outdated
cr = k8s.get_resource(ref)
assert cr['status']['conditions'][0]['message'] == "cannot specify KeyID with NONE encryption type"

# Test the code paths that update encryption type and key ID
Copy link
Contributor Author

@sga80 sga80 May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out this code as I didn't want to check in the actual keyId. Is there anyway we still include this test without breaking E2E tests ?

@sga80
Copy link
Contributor Author

sga80 commented May 30, 2025

@michaelhtm , can you please review?

@sga80
Copy link
Contributor Author

sga80 commented Jun 9, 2025

@michaelhtm , can you please review this PR when you get a chance?

michaelhtm
michaelhtm reviewed Jun 9, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sga80
Thank you for the contribution! We should probably discuss the best approach here.

apis/v1alpha1/generator.yaml
operation: DescribeStreamSummary
path: StreamDescriptionSummary.ConsumerCount
EncryptionType:
is_read_only: true
Copy link
Member

@michaelhtm michaelhtm Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach, although technically correct, is breaking the CRD (removing fields).
Maybe the best thing to do would be to have new fields that go in Spec, and just mirror the ones in status..

cc: @a-hilaly @rushmash91 @knottnt

Copy link
Contributor

@rushmash91 rushmash91 Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, having a similar field in status should be okay rather than removing from read only.

@ack-bot
Copy link
Collaborator

ack-bot commented Dec 6, 2025

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelhtm michaelhtm michaelhtm left review comments

@rushmash91 rushmash91 Awaiting requested review from rushmash91

Assignees

No one assigned

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sga80 @ack-bot @rushmash91 @michaelhtm