SQS controller sets condition ACK.Recoverable for terminal error

[gfaraj]

Describe the bug
The SQS controller sets a status condition of ACK.Recoverable=True when it should be setting ACK.Terminal=True for a non-recoverable error. Specifically the error specified that the name of the queue was invalid (in this case the length was more than 80 characters), which is not recoverable without a manifest change.

Slack thread: https://kubernetes.slack.com/archives/C0402D8JJS1/p1765478110556919

Steps to reproduce

• Create a Queue with a queueName with more than 80 characters.
• Observe the status of the Queue will be set to ACK.Recoverable=True.

Expected outcome
The status of the Queue should be set to ACK.Terminal=True.

Environment

• Kubernetes version
  • 1.33
• Using EKS (yes/no), if so version?
  • Yes, v1.33.5-eks-3025e55
• AWS service targeted (S3, RDS, etc.)
  • SQS (not sure if issue is SQS-specific though)

[github-actions]

Hello @gfaraj 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.