Skip to content

Build with .NET 6, enable VS Code, update min Autofac #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tillig merged 7 commits into from
Jul 17, 2022
Merged

Build with .NET 6, enable VS Code, update min Autofac #30

tillig merged 7 commits into from
Jul 17, 2022

Conversation

@tillig
Copy link
Member

@tillig tillig commented Jul 13, 2022

This library hasn't been released in a while and build tooling/standards were stale. I also couldn't build it on Mac so it was time for an update.

  • Updated build, analyzer rulesets, editorconfig to match core Autofac.
  • Building using .NET 6, still targeting .NET 4.7.2.
    • Enabled nullable warnings.
    • Resolved analyzer issues.
    • Add reference to .NET Framework reference assemblies to allow building on non-Windows platforms.
    • File-scoped namespaces, remove unnecessary usings.
  • Packaging now includes README for display on NuGet.
  • Using .snupkg format symbols.
  • Update minimum Autofac core reference to 6.4.0 to include fixes and additional features by default.
  • Add .vscode folder with settings to enable build. (Tests still don't execute on Mac, but at least we can build.)
  • Increment semver from 6.0.0 => 6.1.0 to indicate the new minimum Autofac version.

tillig added 7 commits July 13, 2022 10:38
@tillig
Build with .NET 6 SDK, enable VS Code support.
f96cc48 
Includes fixes for new analyzer issues found by .NET 6 and updates to
analyzer rulesets, .editorconfig to match core Autofac.
@tillig
Remove unnecessary usings.
432ba74
@tillig
Use file scoped namespaces.
162a9dc
@tillig
Simplify names - namespaces, 'this'
f736fae
@tillig
Build on VS 2022 image.
cfc564b
@tillig
Format README for packaging.
11152b5
@tillig
Remove coverlet.
701a42b 
Tests aren't running and coverlet wasn't here before. Reverting the
project to enable tests to run again.
@tillig tillig mentioned this pull request Jul 14, 2022
Merged
alistairjevans
alistairjevans approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tillig tillig merged commit bcc9f91 into develop Jul 17, 2022
@tillig tillig deleted the feature/vscode-build branch July 17, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alistairjevans alistairjevans alistairjevans approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tillig @alistairjevans