Remove LifetimeScope from OwinContext after it is done being used #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2020 15:02
alistairjevans
requested changes
Nov 24, 2020
Member
alistairjevans
left a comment
alistairjevans
left a comment
There was a problem hiding this comment.
Looks great, thanks. Just one remarks comment block to remove and we're good to go!
alistairjevans
approved these changes
Nov 25, 2020
Member
alistairjevans
left a comment
alistairjevans
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title, the idea here is to remove the LifetimeScope from the OwinContext.Environment so that it is no longer referenced and can be garbage collected earlier.
This PR is to resolve the issue filed here.