This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add AggregateError to classes in non-tree-sitter #698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are *plenty* of unsupported objects: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects, this just adds one
|
This pr is good, it's just that the windows github actions are failing: #696 |
icecream17
changed the title
icecream17
added a commit
to icecream17/language-javascript
that referenced
this pull request
Oct 25, 2021
|
Superseded by #709 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are plenty of unsupported objects: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects, this just adds one
Kinda fixes #697. But tree-sitter still doesn't support
Description of the Change
Add AggregateError
Alternate Designs
There seems to be a vertical column alignment, so it kept it.
Benefits
Slightly more updated code
Possible Drawbacks
Applicable Issues
#697