Enable native builds on Linux aarch64 #670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/aarch64-native
branch
3 times, most recently
from
2aff89e to
1b9b6ce
Compare
This was referenced Jun 28, 2025
zanieb
added a commit
that referenced
this pull request
Jun 28, 2025
I think this will be a useful precursor to #670
zanieb
force-pushed
the
zb/aarch64-native
branch
from
1b9b6ce to
fa119e9
Compare
zanieb
force-pushed
the
zb/aarch64-native
branch
5 times, most recently
from
f8cd0b1 to
801d42a
Compare
This seems to "just work." Let's stay modern.
I think deletion of the legacy proto packages a few commits ago fixed up the build failures the deleted comment alluded to.
I just published an LLVM 20 toolchain for aarch64. The toolchain has support for PGO and BOLT. This commit switches the Linux aarch64 builds to be performed natively on aarch64 machines. PGO and BOLT are enabled on the builds, hopefully making them a bit faster.
zanieb
force-pushed
the
zb/aarch64-native
branch
from
801d42a to
e06fb79
Compare
|
As I mentioned at #607 (comment) — I need to review this myself as I did not review the original implementation and there may be some clean-up to be done after hacking things to work. |
zanieb
commented
Jun 29, 2025
| {"name": "gcc", "arch": "x86_64"}, | ||
| {"name": "gcc.debian9", "arch": "aarch64"}, | ||
| {"name": "xcb.debian9", "arch": "aarch64"}, |
There was a problem hiding this comment.
I think we can drop xcb per #627
zanieb
commented
Jun 29, 2025
| "toolchain-image-gcc", | ||
| "toolchain-image-xcb", | ||
| "toolchain-image-xcb.cross", | ||
| "toolchain-image-xcb.cross-riscv64", | ||
| "toolchain-image-xcb.debian9", |
There was a problem hiding this comment.
zanieb
commented
Jun 29, 2025
| @@ -0,0 +1,3 @@ | |||
| {% include 'build.debian9.Dockerfile' %} | |||
There was a problem hiding this comment.
zanieb
commented
Jun 29, 2025
| @@ -89,13 +89,17 @@ def add_target_env(env, build_platform, target_triple, build_env): | |||
| extra_host_ldflags = [] | |||
|
|
|||
| if build_platform == "linux_x86_64": | |||
| env["BUILD_TRIPLE"] = "x86_64-unknown-linux-gnu" | |||
| machine = platform.machine() | |||
There was a problem hiding this comment.
I guess this section should be refactored to look like the elif build_platform.startswith("macos_"): branch?
zanieb
commented
Jun 29, 2025
| @@ -496,10 +504,14 @@ def python_build_info( | |||
|
|
|||
| binary_suffix = "" | |||
|
|
|||
| if platform == "linux_x86_64": | |||
| if platform in ("linux_x86_64", "linux_aarch64"): | |||
| arch = "aarch64" if platform == "linux_aarch64" else "x86_64" | |||
There was a problem hiding this comment.
We should probably make this exhaustive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #607
Uses #672 and #673 to abstract some of the changes to the CI matrix.