Helm chart notifications #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change when proxy was not set in config, sending notification resulted in notification error: E0728 16:44:53.027020 1 notifications.go:47] error reporting attack for v1.Deployment <NAME> to <URL> with message <MESSAGE> send request: http request: Post "<URL>": proxyconnect tcp: dial tcp :0: connect: connection refused
right trim resulted in `helm template ...` output: ``` ---apiVersion: rbac.authorization.k8s.io/v1beta1 kind: ClusterRoleBinding ```
Collaborator
|
Thanks again @danielllek :) This looks good to me. I'll merge this in a day or two. I'd like to publish a new helm chart version with a few more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Helm chart didn't support notifications (though mentioned in README.md).
Now it works (with additional proxy support)
+some whitespace fixes
🔗 Related Issues
just fixed