Skip to content

Conversation

@jwierzbo
Copy link
Collaborator

@jwierzbo jwierzbo commented Dec 8, 2022

No description provided.

@jwierzbo jwierzbo requested a review from ajanikow December 8, 2022 07:27
@cla-bot cla-bot bot added the cla-signed label Dec 8, 2022
Copy link
Contributor

@informalict informalict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajanikow ajanikow changed the title GT-298 Do not restart member if all pods in group are not ready [Feature] Do not restart member if all pods in group are not ready Dec 8, 2022
@ajanikow ajanikow merged commit ff759b5 into master Dec 8, 2022
@ajanikow ajanikow deleted the GT-298_group_restart branch December 8, 2022 09:28
- (Feature) Switch services to Port names
- (Feature) Configurable ArangoD Port
- (Feature) Allow to exclude metrics
- (Feature) Do not restart member if all pods in group are not ready
Copy link

@Robert-Stam Robert-Stam Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--> Do not restart member if not all pods in group are ready
(otherwise you could have the impression that all pods need to be in the 'not ready' state.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature --> Fix?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robert-Stam We will fix it via next PR

@ajanikow ajanikow changed the title [Feature] Do not restart member if all pods in group are not ready [Feature] Restart members only when Group is Ready Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants