GT-137 image validation for AMD64 arch #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-vanyasin
approved these changes
Nov 1, 2022
jwierzbo
force-pushed
the
GT-137_arm64_version_validation
branch
from
3598ed0 to
337b52c
Compare
jwierzbo
force-pushed
the
GT-137_arm64_version_validation
branch
from
337b52c to
ed59b4d
Compare
ajanikow
reviewed
Nov 7, 2022
pkg/apis/deployment/v1/conditions.go
Outdated
| // ConditionTypeArchitectureMismatch indicates that the member has a different architecture than the deployment. | ||
| ConditionTypeArchitectureMismatch ConditionType = "ArchitectureMismatch" | ||
| // ConditionTypeArchitectureARM64CannotBeApplied indicates that the member has a different architecture than the requested one. | ||
| ConditionTypeArchitectureARM64CannotBeApplied ConditionType = "ArchitectureARM64CannotBeApplied" |
Collaborator
There was a problem hiding this comment.
Add one condition for all archs + reason
ajanikow
requested changes
Nov 7, 2022
ajanikow
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validation handles two cases:
archannotation - we will not let the change arch in member if ArangoDB image is below 3.10