Skip to content

Conversation

@cdelzotti
Copy link

When running tracee with the trace subcommand, a few seconds are wasted while probing for tracee-ebpf capabilities.
This is not required when the user is about to run tracee-ebpf anyway.

Initial Checklist

  • There is an issue describing the need for this PR.
  • Git log contains summary of the change.
  • Git log contains motivation and context of the change.
  • If part of an EPIC, PR git log contains EPIC number.
  • If part of an EPIC, PR was added to EPIC description.

Description (git log)

When running tracee with the trace subcommand, a few seconds are wasted while probing for tracee-ebpf capabilities.
This is not required when the user is about to run tracee-ebpf anyway.

Fixes: #1765

Type of change

  • Bug fix (non-breaking change fixing an issue, preferable).
  • Quick fix (minor non-breaking change requiring no issue, use with care)
  • Code refactor (code improvement and/or code removal)
  • New feature (non-breaking change adding functionality).
  • Breaking change (cause existing functionality not to work as expected).

Final Checklist:

Pick "Bug Fix" or "Feature", delete the other and mark appropriate checks.

  • I have made corresponding changes to the documentation.
  • My code follows the style guidelines (C and Go) of this project.
  • I have performed a self-review of my own code.
  • I have commented all functions/methods created explaining what they do.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix, or feature, is effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published before.

Git Log Checklist:

My commits logs have:

  • Subject starts with "subsystem|file: description".
  • Do not end the subject line with a period.
  • Limit the subject line to 50 characters.
  • Separate subject from body with a blank line.
  • Use the imperative mood in the subject line.
  • Wrap the body at 72 characters.
  • Use the body to explain what and why instead of how.

When running tracee with the trace subcommand, a few seconds are wasted while probing for tracee-ebpf capabilities.
This is not required when the user is about to run tracee-ebpf anyway.

Signed-off-by: cdelzotti <[email protected]>
@cdelzotti
Copy link
Author

I've run the containers generation commands with the Makefile build targets within builder/ and everything seems to be alright

@rafaeldtinoco
Copy link
Contributor

Thanks @cdelzotti. I thought I had done this change already in the past, maybe in a local branch and never pushed. Thank you!.

@rafaeldtinoco rafaeldtinoco self-requested a review August 10, 2022 08:02
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit 42f5074 into aquasecurity:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Probing tracee-ebpf capabilities is not required when using the trace subcommand

2 participants