Skip to content

REST API datasource edit should be always enabled #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2021
Merged

REST API datasource edit should be always enabled #3979

merged 1 commit into from
Apr 20, 2021

Conversation

ApekshaBhosale
Copy link
Contributor

@ApekshaBhosale ApekshaBhosale commented Apr 13, 2021 •
edited
Loading

Description

Edit datasource should be always enabled

Fixes #3978

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link

No changes to code coverage between the base branch and the head branch

@ApekshaBhosale ApekshaBhosale merged commit f509f1b into release Apr 20, 2021
@ApekshaBhosale ApekshaBhosale deleted the fix/enable-edit-datasource branch April 20, 2021 05:42
pedro-santos-rodrigues pushed a commit that referenced this pull request Jun 20, 2024
@sharat87
chore: Bridge on CustomPermissionGroupRepositoryImpl (#3979)
a5e6b3d 
/ok-to-test tags="@tag.Sanity"
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith-ee/actions/runs/8718388820>
> Commit: 7d6ac48b21dab8342a13794016184d0d70ea1e72
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8718388820&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetunandu hetunandu hetunandu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to edit REST API datasource
2 participants
@ApekshaBhosale @hetunandu